Add test and fix for categorical series .shift #10495. #10498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| f_ordered = new_values.flags.f_contiguous | ||
|
|
||
| f_ordered = False | ||
| if not isinstance(new_values, Categorical): |
There was a problem hiding this comment.
just define .flags on Categorical (on the codes array)
|
Pls add release note to |
| for v in values: | ||
| for shift in shifts: | ||
| a = pd.Series(v).shift(shift) | ||
| b = pd.Series(v, dtype='category').shift(shift) |
There was a problem hiding this comment.
this needs to assert that the result series is equal
so construct the expected result as series
|
#10497 fixes this i believe. But pls check. |
|
#10497 is a much better way to do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10495
Waiting for Travis and will review further.